This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Adding Code Hints Description Box for handling additional hint information in LSP#14696
Merged
Adding Code Hints Description Box for handling additional hint information in LSP#14696
Conversation
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LSP allows a server to serve additional information about a completionItem(hint) upon explicit request.
This additional information can be quite large, and doesn't sit nicely with the current UI where all the extra information is shown inline as the element is highlighted.
Current UI:
New UI:
ping @swmitra @narayani28 for review
This feature will be enabled on request through
"enableDescription"option in the hints response. The provider can then subsequently create any html and render in the description box through theupdateHintDescriptioninterface in the provider.See this and this for reference.