This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix #8273: "sortDirectoriesFirst": true in .brackets.json not always working properly #8341
Merged
Fix #8273: "sortDirectoriesFirst": true in .brackets.json not always working properly #8341
Conversation
Contributor
|
Triage Complete. |
Contributor
|
Surprised that this was reported on Mac before Windows. Thanks. Merging. |
redmunds
added a commit
that referenced
this pull request
Jul 16, 2014
Fix #8273: "sortDirectoriesFirst": true in .brackets.json not always working properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is that when using locale compare to compare the filenames, we turn the numeric option to on, so that "1" < "2" < "10". This was done so that we get
Undefined-1, Undefined-2, Undefined-3, Undefined-10, instead ofUndefined-1, Undefined-10, Undefined-2, Undefined-3. But this break the file sorting, since we preppend a0to folders and a1to files. So later we have that "1XX" < "002", where the first is a file and the second a folder. By changing the prefixes to letters, we can fix this.This is for #8273.