This repository was archived by the owner on Sep 6, 2021. It is now read-only.
[Themes] Logic to reuse theme style node#8459
Merged
dangoor merged 4 commits intoadobe:masterfrom Jul 21, 2014
MiguelCastillo:themes-8457
Merged
[Themes] Logic to reuse theme style node#8459dangoor merged 4 commits intoadobe:masterfrom MiguelCastillo:themes-8457
dangoor merged 4 commits intoadobe:masterfrom
MiguelCastillo:themes-8457
Conversation
…heme selection. Also changed ThemeManager around so that the style nodes for themes are reused. Update jsdoc
MiguelCastillo
changed the title
Contributor
Author
|
Hey guys, I made some adjustments to address a a couple of issues. |
add background-blend-mode to expected result
…heme selection. Also changed ThemeManager around so that the style nodes for themes are reused. Update jsdoc
Contributor
|
Nice bit of cleanup. Thanks! |
dangoor
added a commit
that referenced
this pull request
Jul 21, 2014
[Themes] Logic to reuse theme style node
This was referenced Jul 21, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed ThemeManager around so that the style nodes for themes are reused. Also added logic to only process theme prefs events only when there is a theme selection. Update jsdoc
#8457
#8441
#8420