Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Fixes some misspelled words and typos#9365

Closed
kant wants to merge 1 commit intoadobe:masterfrom
kant:patch-2
Closed

Fixes some misspelled words and typos#9365
kant wants to merge 1 commit intoadobe:masterfrom
kant:patch-2

Conversation

@kant
Copy link
Copy Markdown

@kant kant commented Sep 29, 2014

No description provided.

@Mark-Simulacrum
Copy link
Copy Markdown
Contributor

You'll need to sign the Brackets CLA in order to contribute code to Brackets.

@ingorichter
Copy link
Copy Markdown
Contributor

@TomMalbran would you mind have a quick look too? Thanks!

Comment thread src/nls/es/strings.js
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the original translation is better.

@TomMalbran
Copy link
Copy Markdown
Contributor

@ingorichter sure. The changes look good, except for those 2 comments.

@ingorichter
Copy link
Copy Markdown
Contributor

Thanks @TomMalbran! @kant My spanish is pretty bad, so I leave the discussion to you both. We don't have that much time to get these changes into 44. So please make a quick decision. Thanks. :-)

@TomMalbran
Copy link
Copy Markdown
Contributor

If we want this changes for Release 0.44, this PR needs to point to the release branch, and the author still needs to sign the CLA.

@ingorichter
Copy link
Copy Markdown
Contributor

Good point. I think we will create the final build around noon PST. I don't consider it critical if this would make it into 45 instead of 44.

Comment thread src/nls/es/strings.js
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the translation here is not wrong

@TomMalbran
Copy link
Copy Markdown
Contributor

@ingorichter I added the things that I considered that are errors in #9454.

@redmunds
Copy link
Copy Markdown
Contributor

@kant Thanks for your contribution. These strings were updated in PR #9470. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants