Conversation
dafe225 to
04d55a5
Compare
d0876a7 to
84fe514
Compare
84fe514 to
388b0d6
Compare
211d5df to
33fdc50
Compare
33fdc50 to
ec61bcc
Compare
92e9a36 to
695620e
Compare
647ac5f to
5f449a0
Compare
bc5898c to
d38a92c
Compare
a354dcb to
527226f
Compare
670659a to
8a79e77
Compare
dobrerazvan
reviewed
Oct 28, 2025
amuraru
commented
Oct 28, 2025
|
|
||
| WORKDIR /src | ||
| RUN mvn -B -Dmaven.javadoc.skip=true -Dskip.javadoc=true \ | ||
| -Dmaven.compiler.source=21 -Dmaven.compiler.target=21 -Dmaven.compiler.release=21 \ |
Author
There was a problem hiding this comment.
Why not using https://hub.docker.com/r/bitnami/jmx-exporter and docker-hub-remote mirror?
@dobrerazvan the main reason is that I want to align the compilation of jmx_exporter with the same jre target as the kafka itself (i.e java 21). this is an agent attached to the actual broker so I think it's better to control the built of that
dobrerazvan
approved these changes
Oct 28, 2025
8872603 to
8851c74
Compare
Build jmx_exporter from upstream prometheus releases. Currently the jmx-javaagent docker image is built from https://github.com/amuraru/jmx_exporter In order to bring that dependency in-tree here, this PR extends kafka image(s) release (kafka-*) action to also build a docker image directly from https://github.com/prometheus/jmx_exporter The image is published to: https://github.com/adobe/koperator/pkgs/container/koperator%2Fjmx-javaagent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the jmx-javaagent docker image is built from https://github.com/amuraru/jmx_exporter (and it's an old/unmantained version)
In order to bring that dependency in-tree here, this PR extends kafka image(s) release (kafka-*) action to also build a docker image directly from https://github.com/prometheus/jmx_exporter
The image is published to:
https://github.com/adobe/koperator/pkgs/container/koperator%2Fjmx-javaagent