docs: Type check examples #9299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
Member
…ged" This reverts commit f7ec69e.
|
Build successful! 🎉 |
reidbarber
reviewed
Dec 9, 2025
| }); | ||
|
|
||
| export interface RowProps<T> extends Pick<RACRowProps<T>, 'id' | 'columns' | 'children' | 'textValue' | 'dependencies' | keyof GlobalDOMAttributes> {} | ||
| export interface RowProps<T> extends Pick<RACRowProps<T>, 'id' | 'columns' | 'isDisabled' | 'onAction' | 'children' | 'textValue' | 'dependencies' | keyof GlobalDOMAttributes>, LinkDOMProps {} |
reidbarber
reviewed
Dec 9, 2025
reidbarber
reviewed
Dec 9, 2025
reidbarber
reviewed
Dec 9, 2025
| * SelectBoxGroup allows users to select one or more options from a list. | ||
| */ | ||
| export const SelectBoxGroup = /*#__PURE__*/ forwardRef(function SelectBoxGroup<T extends object>(props: SelectBoxGroupProps<T>, ref: DOMRef<HTMLDivElement>) { | ||
| export const SelectBoxGroup = /*#__PURE__*/ (forwardRef as forwardRefType)(function SelectBoxGroup<T extends object>(props: SelectBoxGroupProps<T>, ref: DOMRef<HTMLDivElement>) { |
|
Build successful! 🎉 |
LFDanLu
reviewed
Dec 9, 2025
|
Build successful! 🎉 |
devongovett
commented
Dec 10, 2025
|
Build successful! 🎉 |
|
Build successful! 🎉 |
devongovett
commented
Dec 10, 2025
| // Read entries in directory and update state with relevant info. | ||
| let getFiles = async (dir) => { | ||
| let files = []; | ||
| let getFiles = async (dir: {getEntries(): AsyncIterable<{name: string, kind: string}>}): Promise<DirItem[]> => { |
Member
Author
There was a problem hiding this comment.
Can you use DirectoryDropItem as the type for this?
Suggested change
| let getFiles = async (dir: {getEntries(): AsyncIterable<{name: string, kind: string}>}): Promise<DirItem[]> => { | |
| let getFiles = async (dir: DirectoryDropItem): Promise<DirItem[]> => { |
devongovett
commented
Dec 10, 2025
| name: entry.name, | ||
| kind: entry.kind, | ||
| children: entry.kind === 'directory' ? await getFiles(entry) : [] | ||
| children: entry.kind === 'directory' ? await getFiles(entry as any) : [] |
Member
Author
There was a problem hiding this comment.
If we use DirectoryDropItem this shouldn't be necessary?
|
Build successful! 🎉 |
|
|
||
| export interface Pokemon { | ||
| id: number, | ||
| id?: number, |
Member
There was a problem hiding this comment.
is this really optional? every pokemon has a number
| let ref = useRef<HTMLDivElement>(null); | ||
| let [isSubmenuOpen, setIsSubmenuOpen] = useState(false); | ||
| let [hovered, setHovered] = useState('Option 1'); | ||
| let [, setIsSubmenuOpen] = useState(false); |
Member
There was a problem hiding this comment.
This component was commented out for now. I think @devongovett might add it back later? Just wanted to clean it up so the build passes.
snowystinger
previously approved these changes
Dec 11, 2025
|
Build successful! 🎉 |
## API Changes
react-aria-components/react-aria-components:RangeValue+RangeValue <T> {
+ end: T
+ start: T
+}@react-spectrum/s2/@react-spectrum/s2:SelectBoxGroup SelectBoxGroup <T extends {}> {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
autoFocus?: boolean | FocusStrategy
- children: ReactNode
+ children: ReactNode | ({}) => ReactNode
defaultSelectedKeys?: 'all' | Iterable<Key>
disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
escapeKeyBehavior?: 'clearSelection' | 'none' = 'clearSelection'
isDisabled?: boolean
items?: Iterable<T>
onBlur?: (FocusEvent<Target>) => void
onFocus?: (FocusEvent<Target>) => void
onFocusChange?: (boolean) => void
onSelectionChange?: (Selection) => void
orientation?: Orientation = 'vertical'
selectedKeys?: 'all' | Iterable<Key>
selectionMode?: 'single' | 'multiple' = 'single'
slot?: string | null
styles?: StylesProp
}/@react-spectrum/s2:Row Row <T extends {}> {
children?: ReactNode | (T) => ReactElement
columns?: Iterable<T>
dependencies?: ReadonlyArray<any>
+ download?: boolean | string
+ href?: Href
+ hrefLang?: string
id?: Key
+ isDisabled?: boolean
+ onAction?: () => void
+ ping?: string
+ referrerPolicy?: HTMLAttributeReferrerPolicy
+ rel?: string
+ routerOptions?: RouterOptions
+ target?: HTMLAttributeAnchorTarget
textValue?: string
}/@react-spectrum/s2:SelectBoxGroupProps SelectBoxGroupProps <T> {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
autoFocus?: boolean | FocusStrategy
- children: ReactNode
+ children: ReactNode | (T) => ReactNode
defaultSelectedKeys?: 'all' | Iterable<Key>
disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
escapeKeyBehavior?: 'clearSelection' | 'none' = 'clearSelection'
isDisabled?: boolean
items?: Iterable<T>
onBlur?: (FocusEvent<Target>) => void
onFocus?: (FocusEvent<Target>) => void
onFocusChange?: (boolean) => void
onSelectionChange?: (Selection) => void
orientation?: Orientation = 'vertical'
selectedKeys?: 'all' | Iterable<Key>
selectionMode?: 'single' | 'multiple' = 'single'
slot?: string | null
styles?: StylesProp
}/@react-spectrum/s2:RowProps RowProps <T> {
children?: ReactNode | (T) => ReactElement
columns?: Iterable<T>
dependencies?: ReadonlyArray<any>
+ download?: boolean | string
+ href?: Href
+ hrefLang?: string
id?: Key
+ isDisabled?: boolean
+ onAction?: () => void
+ ping?: string
+ referrerPolicy?: HTMLAttributeReferrerPolicy
+ rel?: string
+ routerOptions?: RouterOptions
+ target?: HTMLAttributeAnchorTarget
textValue?: string
} |
dannify
approved these changes
Dec 11, 2025
snowystinger
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to fix the errors