Update ember-cli to 5.8.1 and add ember-data peer dependencies#190
Update ember-cli to 5.8.1 and add ember-data peer dependencies#190lozjackson wants to merge 15 commits intoadopted-ember-addons:masterfrom
Conversation
|
My apologies, I am no longer involved with this project. Perhaps @mfeckie can assist. |
|
I don't have commit permissions for this project either |
do you have any idea who does? |
|
@MelSumner @Alonski @knownasilya can someone merge this PR please? |
|
looks like there are now a bunch of typescript errors.. I'd appreciate any help resolving those |
knownasilya
left a comment
knownasilya
left a comment
There was a problem hiding this comment.
This might be a good time to switch away from yarn. PNPM has been gaining favor in the ember and the general web dev community as a whole.
Other then that, just a minor comment about the docs.
README.md
Outdated
| // app/serializers/post.js | ||
|
|
||
| import { ActiveModelSerializer } from 'active-model-adapter'; | ||
| import { ActiveModelSerializer } from "active-model-adapter"; |
There was a problem hiding this comment.
I'd keep these single quote, since that's also the rule for the prettier config of this codebase and for new ember apps.
There was a problem hiding this comment.
good spot, for some reason prettier was changing them to double quotes and I hadn't noticed
|
@lozjackson looks like some type lint errors? |
4 participants
This PR updates ember-cli to 5.8.1 and adds
@ember-data/adapterand@ember-data/serializertopeerDependenciesto make this library compatible with ember-data 5.3.8Fixes #189