Skip to content

Added -L infront of dacapo dependency link.#713

Merged
LongyuZhang merged 1 commit intoadoptium:masterfrom
MattyWeee123:TKG710
Jun 19, 2025
Merged

Added -L infront of dacapo dependency link.#713
LongyuZhang merged 1 commit intoadoptium:masterfrom
MattyWeee123:TKG710

Conversation

@MattyWeee123
Copy link
Copy Markdown
Contributor

Fixes: #710

@MattyWeee123 MattyWeee123 marked this pull request as ready for review June 17, 2025 16:41
@llxia
Copy link
Copy Markdown
Contributor

llxia commented Jun 17, 2025

@MattyWeee123 could you rebase your branch to include the latest Maven changes? Your current PR testing failed due to out dated Maven URL.

https://openj9-jenkins.osuosl.org/job/test.getDependency/1514/console

image

Fixes: adoptium#710

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
@llxia
Copy link
Copy Markdown
Contributor

llxia commented Jun 17, 2025

https://ci.adoptium.net/job/dependency_pipeline/ is broken. See adoptium/ci-jenkins-pipelines#1231 for details. As a result, we cannot get jtreg-7.5.2+1.tar.gz (below) and we cannot test this PR.

image

https://openj9-jenkins.osuosl.org/job/test.getDependency/1515/console

@judovana
Copy link
Copy Markdown
Contributor

the jtreg you need is at: https://ci.adoptium.net/view/Dependencies/job/dependency_pipeline/lastBuild/artifact/jtreg/

But I guess you need last-stable build, not some random last one. In that case, you may approve: adoptium/ci-jenkins-pipelines#1232 ;)

@llxia
Copy link
Copy Markdown
Contributor

llxia commented Jun 19, 2025

We cannot use https://openj9-jenkins.osuosl.org/job/test.getDependency/ to test this PR, but I used https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/4419/console to test another code path (which triggered dacapo download).

00:00:50.035  getDependentLibs:
00:00:50.035       [exec] --------------------------------------------
00:00:50.035       [exec] path is set to /home/jenkins/workspace/Grinder/../../testDependency/lib
00:00:50.035       [exec] task is set to default
00:00:50.035       [exec] dependencyList is set to dacapo
00:00:50.035       [exec] --------------------------------------------
00:00:50.035       [exec] Starting download third party dependent jars
00:00:50.035       [exec] --------------------------------------------
00:00:50.035       [exec] downloading dependent third party jars to /home/jenkins/workspace/Grinder/../../testDependency/lib
00:00:50.035       [exec] downloading -L https://download.dacapobench.org/chopin/dacapo-23.11-MR2-chopin-minimal.zip
00:01:16.559       [exec] --> file downloaded to /home/jenkins/workspace/Grinder/../../testDependency/lib/dacapo.zip
00:01:16.559       [exec] downloaded dependent third party jars successfully

Copy link
Copy Markdown
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MattyWeee123

@llxia llxia requested a review from LongyuZhang June 19, 2025 17:12
Copy link
Copy Markdown
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 1828e31 into adoptium:master Jun 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants