Conversation
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
af9547b to
1b8b017
Compare
functional/build.xml
Outdated
| @@ -0,0 +1,60 @@ | |||
| <?xml version="1.0"?> | |||
|
|
|||
| <!-- | |||
There was a problem hiding this comment.
This material would not be Copyright IBM, but rather
<!--
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
-->
There was a problem hiding this comment.
The file was added by accident. Removed.
| --> | ||
|
|
||
| <project name="Security Functional tests" default="build" basedir="."> | ||
| <project name="Adotpium Security Functional tests" default="build" basedir="."> |
There was a problem hiding this comment.
| <project name="Adotpium Security Functional tests" default="build" basedir="."> | |
| <project name="Adoptium Security Functional tests" default="build" basedir="."> |
| Security Functional tests | ||
| </description> | ||
| <import file="${TEST_ROOT}/functional/build.xml"/> | ||
| Adotpium Security Functional tests |
There was a problem hiding this comment.
| Adotpium Security Functional tests | |
| Adoptium Security Functional tests |
|
CryptoTest will be added to functional security as a sub test. Would prefer to move the current security tests net.adoptopenjdk.test to sub directory. @ShelleyLambert is that ok? If it's ok any preference for the tests name? ( in my draft PR I just name it Adoptium by random). |
|
Since this test material originates from rh-openjdk, then that would be an appropriate name to use. |
|
@smlambert I'm talking the tests already exists in aqa-tests/functional/security, which was added by you. I'd like to move that one to a sub dir as one of security tests. |
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
d86247a to
b29bea2
Compare
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
| <src path="${src}" /> | ||
| <classpath> | ||
| <pathelement location="${LIB_DIR}/testng.jar"/> | ||
| <pathelement location="${LIB_DIR}/jcommander.jar"/> |
There was a problem hiding this comment.
testng.jar and jcommand.jar are used, but they are not set before line 23. This will result in failure for the local runs.
Please add the following line before line 23:
<property name="LIB" value="testng,jcommander" />
There was a problem hiding this comment.
The default value of LIB is all. This should not fail the local run though it's alway good to limit to the lib needed.
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
smlambert
left a comment
There was a problem hiding this comment.
thanks @sophia-guo - there is a very recent upstream update to convert this test material for running with jtreg (see https://github.com/rh-openjdk/CryptoTest/pull/29/files, and cc-ed you on an email today). In light of that update, can you update this PR to try and use jtreg to launch the test material please?
|
Move to #4327 using jtreg |

Add Crypotest #3829
Signed-off-by: Sophia Guo sophia.gwf@gmail.com