add howto contribution iteration 1#5471
Merged
karianna merged 7 commits intoadoptium:masterfrom Aug 5, 2024
Merged
Conversation
alignment of step 4 still not perfect
smlambert
reviewed
Jul 31, 2024
Co-authored-by: Shelley Lambert <slambert@gmail.com>
additional review-based changes that were not commited in a batch commit
Contributor
Author
|
review suggestions implemented, however the alignment on step 4. is still off |
step 4 indentation fixed
Co-authored-by: Shelley Lambert <slambert@gmail.com>
karianna
approved these changes
Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
#1558
@smlambert told me, that this is where I am supposed to contribute some documentation to the aqa-tests.. this is something I promised a long time ago. Do I think it is perfect? Hell no.. we can discuss on what to add how to improve it here tho :-)
Cheers!