Skip to content

Support custom config json file#5535

Merged
LongyuZhang merged 1 commit intoadoptium:masterfrom
llxia:mytest
Aug 30, 2024
Merged

Support custom config json file#5535
LongyuZhang merged 1 commit intoadoptium:masterfrom
llxia:mytest

Conversation

@llxia
Copy link
Copy Markdown
Contributor

@llxia llxia commented Aug 29, 2024

related: #5510

related: adoptium#5510

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
@llxia
Copy link
Copy Markdown
Contributor Author

llxia commented Aug 29, 2024

@llxia llxia requested review from LongyuZhang and pshipton August 29, 2024 19:47
Copy link
Copy Markdown
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we also able to do an external run to test for regression?

@llxia
Copy link
Copy Markdown
Contributor Author

llxia commented Aug 29, 2024

This does not affect external runs. The feature is only enabled if the special parameters are set.
If the external run wants this feature, we can address it in a separate issue.

@LongyuZhang LongyuZhang merged commit 6fc63d4 into adoptium:master Aug 30, 2024
llxia added a commit to llxia/aqa-tests that referenced this pull request Aug 30, 2024
related: adoptium#5510

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
LongyuZhang pushed a commit that referenced this pull request Aug 30, 2024
related: #5510

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
llxia added a commit to llxia/aqa-tests that referenced this pull request Aug 30, 2024
related: adoptium#5510

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
LongyuZhang pushed a commit that referenced this pull request Aug 30, 2024
related: #5510

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
llxia added a commit to llxia/aqa-tests that referenced this pull request Sep 6, 2024
related: adoptium#5510

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
pshipton pushed a commit that referenced this pull request Sep 6, 2024
related: #5510

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants