Skip to content

Exclude failing CDS tests on jdk17u mac-x64 as Temurin does not build a CDS#5878

Merged
smlambert merged 1 commit intoadoptium:masterfrom
andrew-m-leonard:mac_exclude
Jan 17, 2025
Merged

Exclude failing CDS tests on jdk17u mac-x64 as Temurin does not build a CDS#5878
smlambert merged 1 commit intoadoptium:masterfrom
andrew-m-leonard:mac_exclude

Conversation

@andrew-m-leonard
Copy link
Copy Markdown
Contributor

We don't build a CDS on Mac x64 (ref: adoptium/adoptium-support#937 (comment))
There are some tests not excluded on jdk17u for mac x64.
Note: jdk21+ excludes all CDS tests when no-CDS ref: https://github.com/openjdk/jdk21u/blob/e45287d1ad9dcadf8a23d3271f1b675b8dade0ac/test/hotspot/jtreg/TEST.groups#L56

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard andrew-m-leonard self-assigned this Jan 17, 2025
Copy link
Copy Markdown
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Copy Markdown
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this in principle, but is the commented out line purely so you can have a second bug URL associated with it (i.e. can we not comma separate for example?)

@andrew-m-leonard
Copy link
Copy Markdown
Contributor Author

I'm ok with this in principle, but is the commented out line purely so you can have a second bug URL associated with it (i.e. can we not comma separate for example?)

Correct, multiple bug URL's is not supported and in fact I think causes the exclude line to be invalid

@smlambert smlambert merged commit e748498 into adoptium:master Jan 17, 2025
andrew-m-leonard added a commit to andrew-m-leonard/aqa-tests that referenced this pull request Jan 17, 2025
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
smlambert pushed a commit that referenced this pull request Jan 17, 2025
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@smlambert
Copy link
Copy Markdown
Contributor

Correct, multiple bug URL's is not supported and in fact I think causes the exclude line to be invalid

Yes, upstream tooling only supports 1 entry per testcase, so if there are multiple entries, only the last one is honoured (earlier ones ignored), so we've decided to take this approach to understand which issues relate to which platforms.

judovana pushed a commit to judovana/aqa-tests that referenced this pull request Mar 11, 2025
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants