Skip to content

Enable tools/jpackage/share disabled by jdk_tools for non jdk17#5891

Merged
sophia-guo merged 3 commits intoadoptium:masterfrom
sophia-guo:tools
Jan 23, 2025
Merged

Enable tools/jpackage/share disabled by jdk_tools for non jdk17#5891
sophia-guo merged 3 commits intoadoptium:masterfrom
sophia-guo:tools

Conversation

@sophia-guo
Copy link
Copy Markdown
Contributor

@sophia-guo sophia-guo commented Jan 21, 2025

Exclude one failing test with alpine by linux-all under adoptium. So test is only excluded for adoptium on other linux platforms including alpine.

Close #3232

See tools/jpackage/share
related #5892
#5893
#5894

Exclude one failing test with alpine by linux-all under adoptium. So
test is only excluded for adoptium on other linux platforms including
alpine.

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
@sophia-guo sophia-guo self-assigned this Jan 21, 2025
@sophia-guo sophia-guo requested a review from smlambert January 21, 2025 21:38
@sophia-guo
Copy link
Copy Markdown
Contributor Author

Will not cherry-pick this for January's release. Need more runs before add to release.

@sophia-guo sophia-guo marked this pull request as draft January 21, 2025 21:45
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
@sophia-guo
Copy link
Copy Markdown
Contributor Author

@sophia-guo sophia-guo marked this pull request as ready for review January 22, 2025 03:18
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Copy link
Copy Markdown
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many testcases does this end up excluding (how many are in jdk_tools target)?

@sophia-guo
Copy link
Copy Markdown
Contributor Author

How many testcases does this end up excluding (how many are in jdk_tools target)?

~450 - 600 testcases differs from jdk version and platforms. Newer version has more testcases. jdk23 ( 600) vs jdk8 ( 450).

@sophia-guo sophia-guo merged commit 7a5b676 into adoptium:master Jan 23, 2025
judovana pushed a commit to judovana/aqa-tests that referenced this pull request Mar 11, 2025
…tium#5891)

* Enable tools/jpackage/share disabled by jdk_tools for non jdk17

Exclude one failing test with alpine by linux-all under adoptium. So
test is only excluded for adoptium on other linux platforms including
alpine.

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>

* Exclude specific problematic jdk_tools testcases on apline

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>

* update tracked issue

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>

---------

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Failing openjdk17 alpine-linux jdk_tools tests

3 participants