Update job status based on parallel and rerun job status#6185
Update job status based on parallel and rerun job status#6185sophia-guo merged 25 commits intoadoptium:masterfrom
Conversation
karianna
left a comment
karianna
left a comment
There was a problem hiding this comment.
I feel that overall we have a state machine here. Might be worth taking a 1,000 foot step back and rethinking how this is designed / coded with that in mind.
buildenv/jenkins/JenkinsfileBase
Outdated
| * If the JOB_NAME contains _rerun, _testList_ or _iteration_, rerun job will not be triggered at the same level. | ||
| */ | ||
| def triggerRerunJob (rerunTestJobParams) { | ||
| //rerunTestJobParams should be part of return of the |
buildenv/jenkins/JenkinsfileBase
Outdated
| def rerunResults = archiveChildJobTap(childJobs, originalStatus) | ||
| currentBuild.result = rerunResults.jobStatus | ||
| } else { | ||
| echo " Either all rerun succeed or there are aborted?" |
There was a problem hiding this comment.
This doesn't quite parse for me
It's certainly a little complex.. but i'd rather take that point as a new "issue". This PR is essential to be able to determine jck success for public users who do not have access to tck......... |
|
I am going to add some documentation / table in the original issue to help clarify the expected behaviour in the various cases. |
sophia-guo
force-pushed
the
status
branch
4 times, most recently
from
cae2b82 to
efabfa0
Compare
sophia-guo
force-pushed
the
status
branch
3 times, most recently
from
7d247d1 to
7006762
Compare
|
Non-parallel
Parallel
|
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
params.PARALLEL is immutable. Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
After the rerun if there is any. Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
|
Rebase and retest https://ci.adoptium.net/view/Test_grinder/job/Grinder/13106/ https://ci.adoptium.net/view/Test_grinder/job/Grinder/13107/ Jobstatus failure is not related with this PR , issue opened adoptium/infrastructure#3951 |
|
OpenJ9 test job are failing with Created #6275 to revert. |
…)" This reverts commit eb09c0b.
|
Just for the record, we noticed Grinder's child job failed, but the overall status is green (pass) internal link during the same time frame. It seems likely to be caused by this change. |
|
Reopen this PR by ##6407. I can reproduce this --grinder , parallel and rerun not enabled https://ci.adoptium.net/job/Grinder/13563/console java.lang.NoSuchMethodError: No such DSL method 'triggerRerunJob' - can not reproduce in adoptium. May need more information. |
6 participants
Close #6000