Skip to content

Exclude java/nio/channels/AsyncCloseAndInterrupt.java aix-all,linux-all#6242

Merged
pshipton merged 1 commit intoadoptium:masterfrom
JasonFengJ9:excludetimedout
May 2, 2025
Merged

Exclude java/nio/channels/AsyncCloseAndInterrupt.java aix-all,linux-all#6242
pshipton merged 1 commit intoadoptium:masterfrom
JasonFengJ9:excludetimedout

Conversation

@JasonFengJ9
Copy link
Copy Markdown
Contributor

Exclude java/nio/channels/AsyncCloseAndInterrupt.java aix-all,linux-all

Match Openjdk and other OpenJ9 version excludes.

Related to

Signed-off-by: Jason Feng fengj@ca.ibm.com

@JasonFengJ9 JasonFengJ9 requested review from llxia and pshipton May 2, 2025 11:20
@pshipton
Copy link
Copy Markdown
Member

pshipton commented May 2, 2025

What about 21?

@pshipton pshipton self-requested a review May 2, 2025 12:11
@pshipton
Copy link
Copy Markdown
Member

pshipton commented May 2, 2025

Why is it being excluded on linux, does it fail on linux too?

@JasonFengJ9
Copy link
Copy Markdown
Contributor Author

java/nio/channels/AsyncCloseAndInterrupt.java was excluded for aix-all,linux-all in all other ProblemList_openjdk_xxx.txt files. This is to match OpenJDK and other OpenJ9 versions.

@pshipton
Copy link
Copy Markdown
Member

pshipton commented May 2, 2025

But if it's not failing for Semeru on Linux, why would we exclude it there? If it is failing on Linux, the openj9 issue(s) should mention this. We don't need to duplicate what adoptium is doing.

I see excludes for dead versions and for jdk24+, but not for jdk21. Does it not fail there as well?

@pshipton
Copy link
Copy Markdown
Member

pshipton commented May 2, 2025

For the excludes jdk24+, they are excluded via adoptium/infrastructure#1173 but this issue is closed saying the tests run successfully and the problematic machines are gone.

To be clear, pls exclude it on platforms where it doesn't work on Semeru infrastructure, but do it consistently and pls document it properly.

@JasonFengJ9 JasonFengJ9 force-pushed the excludetimedout branch 2 times, most recently from a1c6107 to 478735e Compare May 2, 2025 16:29
Updated JDK17 exclude issue comment;
Removed java/nio/channels/AsyncCloseAndInterrupt.java exclude from
JDK24+ since JDK21 doesn't have it.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@JasonFengJ9
Copy link
Copy Markdown
Contributor Author

But if it's not failing for Semeru on Linux, why would we exclude it there? If it is failing on Linux, the openj9 issue(s) should mention this. We don't need to duplicate what adoptium is doing.

So farm Semeru failure was only observed on JDK11 AIX, this PR added it to ProblemList_openjdk11-openj9.txt, updated ProblemList_openjdk17-openj9.txt, also removed java/nio/channels/AsyncCloseAndInterrupt.java exclude from JDK24+ since JDK21 doesn't have it. It can be added back if JDK24+ fails this test.

@pshipton this is ready for another look.

@pshipton
Copy link
Copy Markdown
Member

pshipton commented May 2, 2025

I suspect this isn't complete and you'll want to exclude on AIX for all versions, but that can be done version by version later.

@pshipton pshipton merged commit 91be1b7 into adoptium:master May 2, 2025
3 checks passed
@JasonFengJ9 JasonFengJ9 deleted the excludetimedout branch May 2, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants