Skip to content

Support PERF_ITERATIONS in perfConfig#6409

Merged
karianna merged 1 commit intoadoptium:masterfrom
phat-henry-diep:clean-perf-fix
Jul 17, 2025
Merged

Support PERF_ITERATIONS in perfConfig#6409
karianna merged 1 commit intoadoptium:masterfrom
phat-henry-diep:clean-perf-fix

Conversation

@phat-henry-diep
Copy link
Copy Markdown
Contributor

@phat-henry-diep phat-henry-diep commented Jul 14, 2025

llxia
llxia reviewed Jul 14, 2025
View reviewed changes
llxia
llxia reviewed Jul 14, 2025
View reviewed changes
@phat-henry-diep phat-henry-diep force-pushed the clean-perf-fix branch 2 times, most recently from 74664f2 to 0a36c68 Compare July 16, 2025 16:43
@llxia
Copy link
Copy Markdown
Contributor

llxia commented Jul 16, 2025

@phdiep2003 could you please resolve the merge conflicts and do not include other people's commits in your PR? Thanks

@phat-henry-diep
Copy link
Copy Markdown
Contributor Author

phat-henry-diep commented Jul 16, 2025 •
edited
Loading

@phdiep2003 could you please resolve the merge conflicts and do not include other people's commits in your PR? Thanks

Thank you, I was about to ask you the question. I will do it now!

@phat-henry-diep
Copy link
Copy Markdown
Contributor Author

phat-henry-diep commented Jul 16, 2025

@phdiep2003 could you please resolve the merge conflicts and do not include other people's commits in your PR? Thanks

@llxia I have resolved the conflicts

@llxia
Copy link
Copy Markdown
Contributor

llxia commented Jul 16, 2025

Please keep PERF_ITERATIONS in the perfConfig.json file. Thanks

@phat-henry-diep
Support benchmark-specific PERF_ITERATIONS from perfConfig.json
92c754c 
This patch allows each benchmark in perfConfig.json to define its own PERF_ITERATIONS.
If not specified, it falls back to the global parameter or default value (4).

Fixes: adoptium#6381
Signed-off-by: Phat Diep  <phdiep@andrew.cmu.edu>
llxia
llxia approved these changes Jul 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia requested a review from LongyuZhang July 17, 2025 00:26
@karianna
Copy link
Copy Markdown
Contributor

karianna commented Jul 17, 2025

Why 3 as a default in pnce place and 4 in another?

@phat-henry-diep
Copy link
Copy Markdown
Contributor Author

phat-henry-diep commented Jul 17, 2025

Why 3 as a default in pnce place and 4 in another?

The perfConfig.json file is a benchmark-specific configuration file. If user don't specified PERF_ITERATIONS, the default value of 4 will be used by the performance pipeline. I chose 3 for the distinction with the default value.

@karianna karianna merged commit bd8bb23 into adoptium:master Jul 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karianna karianna karianna approved these changes

@llxia llxia llxia approved these changes

@LongyuZhang LongyuZhang Awaiting requested review from LongyuZhang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support PERF_ITERATIONS in perfConfig

3 participants

@phat-henry-diep @llxia @karianna