Skip to content

Renamed testDependency to externalDependency#6505

Merged
karianna merged 1 commit intoadoptium:masterfrom
Amrutha-Kanhirathingal:renameToexternal
Aug 21, 2025
Merged

Renamed testDependency to externalDependency#6505
karianna merged 1 commit intoadoptium:masterfrom
Amrutha-Kanhirathingal:renameToexternal

Conversation

@Amrutha-Kanhirathingal
Copy link
Copy Markdown
Contributor

@Amrutha-Kanhirathingal Amrutha-Kanhirathingal commented Aug 14, 2025

Updated env.LIB_DIR value by renaming testDependency to externalDependency.

Related : runtimes/automation/issues/166

@Amrutha-Kanhirathingal
Renamed testDependency to externalDependency
2b34f7e 
Related : runtimes/automation/issues/166

Signed-off-by:Amrutha Kanhirathingal <Amrutha.Kanhirathingal@ibm.com>
@karianna
Copy link
Copy Markdown
Contributor

karianna commented Aug 14, 2025

#5675

@karianna karianna requested a review from smlambert August 14, 2025 09:21
@llxia
Copy link
Copy Markdown
Contributor

llxia commented Aug 14, 2025

Waiting for Grinder links

@llxia
Copy link
Copy Markdown
Contributor

llxia commented Aug 20, 2025 •
edited
Loading

Grinder links

2025-08-19T18:53:34.854Z] --------------------------------------------
[2025-08-19T18:53:34.854Z] Starting download third party dependent jars
[2025-08-19T18:53:34.854Z] --------------------------------------------
[2025-08-19T18:53:34.854Z] downloading dependent third party jars to /home/jenkins/workspace/Grinder/../../externalDependency/lib
[2025-08-19T18:53:34.854Z] downloading https://openj9-jenkins.osuosl.org/job/test.getDependency/lastSuccessfulBuild/artifact//commons-exec.jar
[2025-08-19T18:53:35.261Z] --> file downloaded to /home/jenkins/workspace/Grinder/../../externalDependency/lib/commons-exec.jar
[2025-08-19T18:53:35.261Z] downloading https://openj9-jenkins.osuosl.org/job/test.getDependency/lastSuccessfulBuild/artifact//jtreg_6_1.tar.gz.sha256sum.txt
[2025-08-19T18:53:35.681Z] --> file downloaded to /home/jenkins/workspace/Grinder/../../externalDependency/lib/jtreg_6_1.tar.gz.sha256sum.txt
...

llxia
llxia approved these changes Aug 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia
Copy link
Copy Markdown
Contributor

llxia commented Aug 20, 2025

Friendly reminder: After the merge, the PR needs to be ported into https://github.com/adoptium/aqa-tests/tree/v1.0.9-release

@karianna karianna merged commit 2150879 into adoptium:master Aug 21, 2025
2 checks passed
@karianna
Copy link
Copy Markdown
Contributor

karianna commented Aug 21, 2025

@Amrutha-Kanhirathingal - note @llxia's backport comment :-)

Amrutha-Kanhirathingal added a commit to Amrutha-Kanhirathingal/aqa-tests that referenced this pull request Aug 21, 2025
@Amrutha-Kanhirathingal
Renamed testDependency to externalDependency (adoptium#6505)
18ceef1 
Related : runtimes/automation/issues/166

Signed-off-by:Amrutha Kanhirathingal <Amrutha.Kanhirathingal@ibm.com>
llxia pushed a commit that referenced this pull request Aug 22, 2025
@Amrutha-Kanhirathingal
Renamed testDependency to externalDependency (#6505) (#6527)
d9a86b4 
Related : runtimes/automation/issues/166

Signed-off-by:Amrutha Kanhirathingal <Amrutha.Kanhirathingal@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karianna karianna karianna approved these changes

@llxia llxia llxia approved these changes

@smlambert smlambert Awaiting requested review from smlambert

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Amrutha-Kanhirathingal @karianna @llxia