Skip to content

Update genTestFolderList to dynamically detect test directories#6775

Merged
smlambert merged 4 commits intoadoptium:masterfrom
Agaba-derrick:Update-genTestFolderList-to-dynamically-detect-test-directories
Dec 9, 2025
Merged

Update genTestFolderList to dynamically detect test directories#6775
smlambert merged 4 commits intoadoptium:masterfrom
Agaba-derrick:Update-genTestFolderList-to-dynamically-detect-test-directories

Conversation

@Agaba-derrick
Copy link
Copy Markdown
Contributor

Summary

This PR updates genTestFolderList to dynamically discover JCK test directories instead of relying on hard-coded version-specific paths. This ensures new test targets are automatically detected as the JCK layout evolves.

What Changed

  • Removed version-based directory assumptions (e.g., *-runtime-$ver)
  • Added dynamic directory scanning for:
    • runtime
    • compiler
    • devtools
  • Improved resilience to future JCK repository structure changes

Why

As test materials evolve over time, the previous static approach could miss new test folders. This update keeps target detection accurate and future-proof.

Issue

Closes #6761

Signed-off-by: Agaba-derrick <agabaderrick18@gmail.com>
@Agaba-derrick
Copy link
Copy Markdown
Contributor Author

Agaba-derrick commented Dec 5, 2025

@llxia @smlambert kindly asking for a review

@smlambert
Copy link
Copy Markdown
Contributor

hi @Agaba-derrick - this is not the change I expected for this one. I was hoping for the most minimal change to this file, essentially changing this block
to

	if [ "$VERSION" -eq 8 ] ; then 
		ver="$VERSION"c
	elif [ "$VERSION" -eq 11 ] ; then 
		ver="$VERSION"a
	else 
		ver="$VERSION"
	fi 

@Agaba-derrick
Copy link
Copy Markdown
Contributor Author

hi @Agaba-derrick - this is not the change I expected for this one. I was hoping for the most minimal change to this file, essentially changing this block to

	if [ "$VERSION" -eq 8 ] ; then 
		ver="$VERSION"c
	elif [ "$VERSION" -eq 11 ] ; then 
		ver="$VERSION"a
	else 
		ver="$VERSION"
	fi 

thanks @smlambert i will change this Asap !

Signed-off-by: Agaba-derrick <agabaderrick18@gmail.com>
@smlambert
Copy link
Copy Markdown
Contributor

@Agaba-derrick - see these lines, you will need to deal with both 11 and 17 (my example only did 11)

Signed-off-by: Agaba-derrick <agabaderrick18@gmail.com>
@smlambert smlambert requested a review from sophia-guo December 5, 2025 15:24
@smlambert
Copy link
Copy Markdown
Contributor

@Agaba-derrick - please address @sophia-guo 's recent review comments after which we will be good to merge

@Agaba-derrick
Copy link
Copy Markdown
Contributor Author

@smlambert le me work on these Asap

Signed-off-by: Agaba-derrick <agabaderrick18@gmail.com>
@sophia-guo sophia-guo requested a review from smlambert December 9, 2025 14:26
Copy link
Copy Markdown
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @Agaba-derrick !

@smlambert smlambert merged commit 3e7499f into adoptium:master Dec 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update genTestFolderList to search updated directories

3 participants