Update genTestFolderList to dynamically detect test directories#6775
Merged
smlambert merged 4 commits intoadoptium:masterfrom Dec 9, 2025
Conversation
Signed-off-by: Agaba-derrick <agabaderrick18@gmail.com>
Contributor
Author
|
@llxia @smlambert kindly asking for a review |
Contributor
|
hi @Agaba-derrick - this is not the change I expected for this one. I was hoping for the most minimal change to this file, essentially changing this block |
Contributor
Author
thanks @smlambert i will change this Asap ! |
Signed-off-by: Agaba-derrick <agabaderrick18@gmail.com>
Contributor
|
@Agaba-derrick - see these lines, you will need to deal with both 11 and 17 (my example only did 11) |
Signed-off-by: Agaba-derrick <agabaderrick18@gmail.com>
sophia-guo
reviewed
Dec 5, 2025
sophia-guo
reviewed
Dec 5, 2025
Contributor
|
@Agaba-derrick - please address @sophia-guo 's recent review comments after which we will be good to merge |
Contributor
Author
|
@smlambert le me work on these Asap |
Signed-off-by: Agaba-derrick <agabaderrick18@gmail.com>
sophia-guo
approved these changes
Dec 9, 2025
smlambert
approved these changes
Dec 9, 2025
Contributor
smlambert
left a comment
There was a problem hiding this comment.
thank you @Agaba-derrick !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
genTestFolderListto dynamically discover JCK test directories instead of relying on hard-coded version-specific paths. This ensures new test targets are automatically detected as the JCK layout evolves.What Changed
*-runtime-$ver)runtimecompilerdevtoolsWhy
As test materials evolve over time, the previous static approach could miss new test folders. This update keeps target detection accurate and future-proof.
Issue
Closes #6761