-
Notifications
You must be signed in to change notification settings - Fork 266
Description
Describe the bug
I ran your implementation on M1, M3 and Tourism competition dataset, and found several cases, where the function fails or produces unreasonable forecasts.
Steps/Code to reproduce the bug
Install the package with the datasets
pip install fcompdataLoad the data
from fcompdata import M1, M3Here is where it fails:
series = M1[83]
model = AeonAutoETS()
model.fit(series.x)
forecast = model.iterative_forecast(series.x, prediction_horizon=series.h)
print(forecast)[nan nan nan nan nan nan]
And here I get extremely high point forecasts:
series = M3[113]
model = AeonAutoETS()
model.fit(series.x)
forecast = model.iterative_forecast(series.x, prediction_horizon=series.h)
print(forecast)[7.82501581e+04 3.39696794e+05 2.72884577e+06 5.25038119e+07
3.48929606e+09 1.34675105e+12]
The latter could be due to the multiplicative trend (if it is selected). If that's the case, I would suggest switching it off by default (all ets implementations do that). But even in case of multiplicative trend, other implementations produce more reasonable forecasts. e.g.:
[8819.883 9853.339 10978.959 12197.934 13594.791 15163.362]
Expected results
The first example should produce something like this:
[735.8964 756.7602 777.6240 798.4879 819.3517 840.2156]
The second one:
[8819.883 9853.339 10978.959 12197.934 13594.791 15163.362]
Actual results
In case of the first example, I get:
[nan nan nan nan nan nan]
For the second one:
[7.82501581e+04 3.39696794e+05 2.72884577e+06 5.25038119e+07
3.48929606e+09 1.34675105e+12]