Skip to content

[MNT] Add tests for BA weight parameters#1570

Merged
chrisholder merged 3 commits intomainfrom
ba-weight-tests
May 25, 2024
Merged

[MNT] Add tests for BA weight parameters#1570
chrisholder merged 3 commits intomainfrom
ba-weight-tests

Conversation

@chrisholder
Copy link
Copy Markdown
Contributor

@chrisholder chrisholder commented May 25, 2024

Reference Issues/PRs

This PR adds missing tests from PR #1563

What does this implement/fix? Explain your changes.

The BA weights parameter was missing tests so this PR adds those tests.

Does your contribution introduce a new dependency? If yes, which one?

No

Any other comments?

No

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@aeon-actions-bot aeon-actions-bot bot added clustering Clustering package maintenance Continuous integration, unit testing & package distribution labels May 25, 2024
@aeon-actions-bot
Copy link
Copy Markdown
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#4011F3}{\textsf{clustering}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@chrisholder chrisholder marked this pull request as ready for review May 25, 2024 13:56
@chrisholder chrisholder requested a review from TonyBagnall as a code owner May 25, 2024 13:56
Copy link
Copy Markdown
Member

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisholder chrisholder merged commit feba842 into main May 25, 2024
@chrisholder chrisholder deleted the ba-weight-tests branch May 25, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clustering Clustering package maintenance Continuous integration, unit testing & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants