You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What does this implement/fix? Explain your changes.
Add network specific tests to improve coverage of DL networks :
inception network coverage 67% -> 100%
encoder network coverage 13% -> 100%
cnn network coverage 98% -> 99% (last percent is from a deprecated class)
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
AE networks have been ignored as they already have someone working on it with specific tests ref.
There are also 2 networks that can have a better coverage (lite and tapnet) but that have been ignored as they are already skipped in test_all_networks, see #1867.
The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#379E11}{\textsf{networks}}$ ]. Feel free to change these if they do not properly represent the PR.
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.
Don't hesitate to ask questions on the aeonSlack channel if you have any.
PR CI actions
These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
Run pre-commit checks for all files
Run all pytest tests and configurations
Run all notebook example tests
Run numba-disabled codecov tests
Stop automatic pre-commit fixes (always disabled for drafts)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codecov actionsRun the codecov action on a PRenhancementNew feature, improvement request or other non-bug code enhancementnetworksNetworks package
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Improves #1233
What does this implement/fix? Explain your changes.
Add network specific tests to improve coverage of DL networks :
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
AE networks have been ignored as they already have someone working on it with specific tests ref.
There are also 2 networks that can have a better coverage (lite and tapnet) but that have been ignored as they are already skipped in test_all_networks, see #1867.
PR checklist
For all contributions