[DOC] Added Type Hints for _dilated_shapelet_transform #1949
[DOC] Added Type Hints for _dilated_shapelet_transform #1949baraline merged 13 commits intoaeon-toolkit:mainfrom aryanpola:main
Conversation
Thank you for contributing to
|
|
Hi, I can take a look at this in a bit if you are still having issues. Feel free to @ me with any questions. @baraline left a comment on your previous PR so im sure he would be open to questions as well |
MatthewMiddlehurst
left a comment
There was a problem hiding this comment.
Some changes required IMO, @baraline might have more for the later function hints
aeon/transformations/collection/shapelet_based/_dilated_shapelet_transform.py
Show resolved
Hide resolved
aeon/transformations/collection/shapelet_based/_dilated_shapelet_transform.py
Show resolved
Hide resolved
aeon/transformations/collection/shapelet_based/_dilated_shapelet_transform.py
Outdated
Show resolved
Hide resolved
|
@baraline Is there any reason for the tests to be canceled, they were all successful when I committed but got canceled when I updated the branch. |
|
I don't think that should be happening, let me check |
baraline
left a comment
There was a problem hiding this comment.
Re-runned the test, maybe something went wrong with the CI pipeline ? Some small changes and we should be good to go !
aeon/transformations/collection/shapelet_based/_dilated_shapelet_transform.py
Outdated
Show resolved
Hide resolved
aeon/transformations/collection/shapelet_based/_dilated_shapelet_transform.py
Outdated
Show resolved
Hide resolved
aeon/transformations/collection/shapelet_based/_dilated_shapelet_transform.py
Outdated
Show resolved
Hide resolved
aeon/transformations/collection/shapelet_based/_dilated_shapelet_transform.py
Outdated
Show resolved
Hide resolved
aeon/transformations/collection/shapelet_based/_dilated_shapelet_transform.py
Outdated
Show resolved
Hide resolved
aeon/transformations/collection/shapelet_based/_dilated_shapelet_transform.py
Outdated
Show resolved
Hide resolved
aeon/transformations/collection/shapelet_based/_dilated_shapelet_transform.py
Outdated
Show resolved
Hide resolved
|
Some changes were made to the file you are working with on #1959, which added two parameters to the |
Are there any changes that I am supposed to make? |
|
Yes, could you should first merge the main branch into this and had the type hints for the new parameters of the functions I listed ? |
Added the type hints after merging the main branch. Is there anything else to do? |
aeon/transformations/collection/shapelet_based/_dilated_shapelet_transform.py
Show resolved
Hide resolved
|
Just need to resolve the remaining conversation, and we'll be good to go I think ! 😄 |
aeon/transformations/collection/shapelet_based/_dilated_shapelet_transform.py
Show resolved
Hide resolved
baraline
left a comment
There was a problem hiding this comment.
Looking good to me! Thanks for your patience! 😄
Thanks a lot for the help! |
Changes have been adressed
What does this implement/fix? Explain your changes.
I have added type hints for function variables and return values as described in issue.
#1910