[DOC] Update adding_typehints.md#2433
Conversation
added "from __future__ import annotations" to adding_typehints.md
Thank you for contributing to
|
|
@SebastianSchmidl is this what i had to do |
|
Dear @vedpawar2254, Can you expand the explanation to include the considerations, we discussed in Slack?
The example is also still incorrect. def _is_pyod_model(model: Any) -> bool:
"""Check if the provided model is a PyOD model."""
from pyod.models.base import BaseDetector
return isinstance(model, BaseDetector)is completely unrelated. The |
|
Yeah definitely, you are right I'll do that |
added "from future import annotations" to adding_typehints.md
Reference Issues/PRs
Fixes #1857 and update to PR #2424
What does this implement/fix? Explain your changes.
added "from future import annotations" to adding_typehints.md so that Python doesn't try to evaluate it until it's necessary
PR checklist
For all contributions