Skip to content

[MNT] Fixed wrong type annotations for aeon classes#2488

Merged
SebastianSchmidl merged 1 commit intoaeon-toolkit:mainfrom
shinymack:fix/type_hints
Jan 11, 2025
Merged

[MNT] Fixed wrong type annotations for aeon classes#2488
SebastianSchmidl merged 1 commit intoaeon-toolkit:mainfrom
shinymack:fix/type_hints

Conversation

@shinymack
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Fixes #1928

What does this implement/fix? Explain your changes.

Fixed incorrect type hinting in private methods for _TreeNode and PCA

  1. Changed type hint for the _find_splits_gain method in _continuous_interval_tree.py from type[_TreeNode] to _TreeNode.
  2. Updated the type hint for pcas in _predict_for_estimator and _predict_proba_for_estimator methods in _rotation_forest_classifier.py and _rotation_forest_regressor.py from type[PCA] to PCA.

The changes correct type hints by using class instances instead of class types for _TreeNode and PCA.

Does your contribution introduce a new dependency? If yes, which one?

No

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator/function to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@aeon-actions-bot aeon-actions-bot bot added classification Classification package maintenance Continuous integration, unit testing & package distribution regression Regression package labels Jan 10, 2025
@aeon-actions-bot
Copy link
Copy Markdown
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$, $\color{#7E0206}{\textsf{regression}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@SebastianSchmidl SebastianSchmidl merged commit 3cfc60e into aeon-toolkit:main Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

classification Classification package maintenance Continuous integration, unit testing & package distribution regression Regression package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNT] Wrong type annotations for aeon classes

2 participants