[ENH] Add RehabPile dataset collection#2993
Conversation
Thank you for contributing to
|
|
hi, thanks for this, you might want to install pre-commit, that will pick up formatting errors before running CI |
2c743bb to
7d9b973
Compare
|
the CI is failing on a TimeCNNRegressor test in test_all_estimators.py, which seems unrelated to my dataset loader PR. I have already tried re-running the failed job, but the error persists. |
hadifawaz1999
left a comment
There was a problem hiding this comment.
Thanks for this. The loader should take into consideration that there is multiple resamples (folds) per dataset. The default split to load should be always fold 0, but there is multiple folds per dataset. The information of number of folds (resamples or splits) per dataset is available here: https://github.com/MSD-IRIMAS/DeepRehabPile/blob/main/DeepRehabPileForExperiments.json
|
Maybe we need to start subgrouping these, it will get confusing if we start putting specific loaders alongside the general ones |
4fc27f3 to
a4d0b80
Compare
hadifawaz1999
left a comment
There was a problem hiding this comment.
Thank you very much for your effort on this. I left some comments, with one additional functionality needed and others are docs stuff and placements
aebd571 to
70efd89
Compare
70efd89 to
048ce39
Compare
9d1a33c to
9c45447
Compare
hadifawaz1999
left a comment
There was a problem hiding this comment.
Can you add the three functions to the api reference here ? https://github.com/aeon-toolkit/aeon/blob/main/docs/api_reference/datasets.md
6f066ec to
9abac38
Compare
02bd0ab to
c85b903
Compare
Reference Issues/PRs
Fixes #2989
What does this implement/fix? Explain your changes.
This PR introduces support for the RehabPile dataset collection, which contains time series datasets for both classification and regression tasks.
The implementation includes:
Does your contribution introduce a new dependency? If yes, which one?
No, this contribution does not introduce any new dependencies. It uses standard libraries and existing aeon dependencies like numpy and pandas.
Any other comments?
The new loader was designed to align closely with the existing architectural patterns of the aeon.datasets module, ensuring a consistent user experience and maintainability.
API documentation for the new functions may need to be added as a follow-up.
PR checklist
For all contributions
For new estimators and functions
For developers with write access