[ENH] Add primitive type hints to segmentation module#3252
[ENH] Add primitive type hints to segmentation module#3252SebastianSchmidl merged 10 commits intoaeon-toolkit:mainfrom
Conversation
Thank you for contributing to
|
1b4a105 to
0be2244
Compare
|
Hi maintainers |
|
Hi @MatthewMiddlehurst 👋 |
|
Thank you for addressing the comments. Please view the failing test output. |
70b9a4e to
e62caea
Compare
Co-authored-by: Sebastian Schmidl <10573700+SebastianSchmidl@users.noreply.github.com>
e62caea to
a4f6833
Compare
3da366f to
55fff46
Compare
|
All checks passing now! Fixed the doctest issues in |
MatthewMiddlehurst
left a comment
There was a problem hiding this comment.
Please avoid force pushing in the future is makes reviewing more difficult.
|
Hi @SebastianSchmidl |
0968b43 to
44444fb
Compare
|
@MatthewMiddlehurst @SebastianSchmidl The pre-commit CI is failing due to a shallow clone/merge-base issue Ready for re-review whenever you get a chance. Thanks and again apologies for my mistake! |
|
@MatthewMiddlehurst The failing test ( |
Reference Issues / PRs
Relates to #1454
What does this implement / fix?
This PR adds type hints for primitive and string parameters (
int,float,bool,str) in the segmentation module, following the scope defined in issue #1454.Files modified:
aeon/segmentation/_clasp.pyaeon/segmentation/_fluss.pyaeon/segmentation/_binseg.pyaeon/segmentation/_random.pyaeon/segmentation/_eagglo.pyChanges made:
Testing:
Does your contribution introduce a new dependency?
No. This change does not introduce any new dependencies.
Additional comments
Please let me know if you'd prefer the scope to be split into smaller PRs or adjusted further.
PR Checklist
For all contributions
[ENH].For new estimators and functions