Refactoring inspect#146
Closed
davidyuk wants to merge 1 commit intoaeternity:developfrom
davidyuk:refactoring-inspect
Closed
Refactoring inspect#146davidyuk wants to merge 1 commit intoaeternity:developfrom davidyuk:refactoring-inspect
davidyuk wants to merge 1 commit intoaeternity:developfrom
davidyuk:refactoring-inspect
Conversation
Member
Author
|
@nduchak Did you look at the last commit in this PR? What do you think about this? |
Contributor
Looks good to me. Please do. |
Member
Author
|
The above is mostly implemented in other PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR represents my vision regarding how stuff in this repository should be done. If it is fine, I can refactor other commands in this way.