This repository was archived by the owner on Sep 3, 2023. It is now read-only.
Customizing the message: Allow to act on messageTextView directly#1837
Closed
phatnhse wants to merge 1 commit intoafollestad:masterfrom
phatnhse:visibility-modifier-to-custom-textview-message
Closed
Customizing the message: Allow to act on messageTextView directly#1837phatnhse wants to merge 1 commit intoafollestad:masterfrom phatnhse:visibility-modifier-to-custom-textview-message
phatnhse wants to merge 1 commit intoafollestad:masterfrom
phatnhse:visibility-modifier-to-custom-textview-message
Conversation
Author
|
Hi @afollestad affo, would you mind looking on this? |
sahil-sdei
approved these changes
Jul 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the modifier of
messageTextViewin order to make it consistent between the instruction and the implementation.Base on the instruction above, the
messageTextViewshould be accessible but it's currently private.I created method
getMessageTextView()to expose it.