Skip to content

fix: Gemini client support for messages without role (A2A)#2358

Merged
priyansh4320 merged 2 commits intomainfrom
fix/gemini-client-message-role
Jan 29, 2026
Merged

fix: Gemini client support for messages without role (A2A)#2358
priyansh4320 merged 2 commits intomainfrom
fix/gemini-client-message-role

Conversation

@marklysze
Copy link
Collaborator

Why are these changes needed?

A2A messages, when converted and sent through to the AG2 Gemini client, do not have role on them. The Gemini client class currently assumes it has role on a message. This handles this by defaulting it to user if not provided.

Related issue number

N/A

Checks

@joggrbot
Copy link
Contributor

joggrbot bot commented Jan 29, 2026

📝 Documentation Analysis

All docs are up to date! 🎉


✅ Latest commit analyzed: 6f0724a | Powered by Joggr

Copy link
Collaborator

@priyansh4320 priyansh4320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marklysze , awesome contribution.

@priyansh4320 priyansh4320 added this pull request to the merge queue Jan 29, 2026
Merged via the queue into main with commit de13b2f Jan 29, 2026
19 checks passed
@priyansh4320 priyansh4320 deleted the fix/gemini-client-message-role branch January 29, 2026 09:58
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
autogen/oai/gemini.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
autogen/oai/gemini.py 16.12% <0.00%> (-46.42%) ⬇️

... and 115 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

priyansh4320 added a commit that referenced this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants