Skip to content

Broken external link: GitHub notebook reliable_basic_example.ipynb#2645

Closed
VasiliyRad wants to merge 2 commits intomainfrom
elva/fix-968bb52c
Closed

Broken external link: GitHub notebook reliable_basic_example.ipynb#2645
VasiliyRad wants to merge 2 commits intomainfrom
elva/fix-968bb52c

Conversation

@VasiliyRad
Copy link
Copy Markdown
Contributor

Files changed:

  • website/snippets/components/GalleryPage.mdx

What I checked before submitting:

The fix is correct, minimal, and well-scoped. Upgrading the regex from /^\// to /^\/+/ properly strips all leading slashes from item.source before interpolating it into GitHub/Colab URL templates. This robustly prevents double-slash (and multi-slash) URL construction that was causing HTTP 404s.

What was verified:

  • The regex change correctly handles item.source values with one or more leading slashes (e.g., //notebook/...) — the previous single-slash strip would leave one slash behind, producing main//notebook/....
  • Items with no leading slash are unaffected (regex simply doesn't match).
  • The notebook/ directory at https://github.com/ag2ai/ag2/tree/main/notebook is valid and resolves correctly.
  • The specific file reliable_basic_example.ipynb appears to have been removed from the repo — but that is a separate content issue unrelated to the URL construction logic fixed here.
  • Code style is idiomatic and matches the surrounding JSX/JS patterns.

Note for PR author: The notebook file reliable_basic_example.ipynb no longer exists at https://github.com/ag2ai/ag2/blob/main/notebook/reliable_basic_example.ipynb — it may have been renamed or deleted. Consider auditing stale notebook references in the gallery data source separately from this URL construction fix.


Like a river carves its path — small, steady changes shape the landscape. Fixed by Elva.

…c_example.ipynb

GitHub link with double slash returns HTTP 404 across multiple older versioned docs pages.

Bug: file-968bb52c
Fixed by Elva.
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 13, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Lancetnik
❌ Elva


Elva seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Apr 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Lancetnik Lancetnik closed this Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants