Fix inconsistent tool validation and prevent system crashes on misformatted requests (Fixes #1349)#1481
Open
mdnaimul22 wants to merge 2 commits intoagent0ai:mainfrom
Open
Conversation
…matted requests (Fixes agent0ai#1349)
… instructions and usage examples
mdnaimul22
force-pushed
the
fix-tool-validation-consistency
branch
from
4f720b0 to
35bd59e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
ValueError: Tool request must have a tool_name (type string) fielderror (see #1349).Changes:
validate_tool_requestinagent.pyto supporttoolandargsaliases matching the extraction logic inprocess_tools.ValueErrortoRepairableException. This allows the message loop to stay alive and surfaces the format error back to the model for self-repair.This fix significantly improves framework stability when using models that might deviate slightly from the expected JSON schema.