Skip to content

fix: normalize incomplete tool requests at extraction layer #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gdeyoung wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

fix: normalize incomplete tool requests at extraction layer #1483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions helpers/extract_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,16 @@ def json_parse_dirty(json: str) -> dict[str, Any] | None:
try:
data = DirtyJson.parse_string(ext_json)
if isinstance(data, dict):
# Normalize: if it looks like a tool request, ensure required fields exist
if "tool_name" in data or "tool" in data:
# Normalize tool_name (some models use "tool" instead of "tool_name")
if "tool" in data and "tool_name" not in data:
data["tool_name"] = data.pop("tool")
# Normalize tool_args — default to empty dict if missing or not a dict
if "tool_args" not in data:
data["tool_args"] = data.get("args", {})
if not isinstance(data.get("tool_args"), dict):
data["tool_args"] = {}
return data
except Exception:
# If parsing fails, return None instead of crashing
Expand Down