Open
Conversation
- add groups for future use - compare results to other implementations
- use test cases as seeds - add random seeds - compare results to other implementations - compare results to Hamming distance
- benchmarks use test cases by group - split benchmarks for others levenshtein implementations
new targets: - benchAll compares performance of all levenshtein distance implementations - cover runs the tests and opens a web browser displaying annotated source code - fuzz runs all fuzzing functions - perf compares performance using benchstat between the last commit and uncommitted code
Owner
|
Thanks a lot Paul for this! Please allow me to find some time to review the code. |
Owner
|
Dear me, my apologies @psadac , this totally dropped from my radar! Are you still available to merge the PR if I begin a review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had already worked on the tests, fuzzing and benchmarks some months ago, but didn't push the changes.
A lot of changes were made to add tests on long strings and to avoid duplicating test cases.