Fix for missing glist_findrtext in new Pd versions
#76
Conversation
|
ah, sorry - had tim's changes in my branch here already! will reset to master and force push ... EDIT: done |
ben-wes
force-pushed
the
fix/glist_getrtext
branch
from
9fbb9b3 to
3011112
Compare
ben-wes
force-pushed
the
fix/glist_getrtext
branch
from
3011112 to
d27256c
Compare
ben-wes
force-pushed
the
fix/glist_getrtext
branch
from
d27256c to
14c2892
Compare
ben-wes
force-pushed
the
fix/glist_getrtext
branch
from
14c2892 to
e4524e1
Compare
pdlua.c
Outdated
| static t_signal_setmultiout g_signal_setmultiout; | ||
| // function pointer type for signal_setmultiout (added with Pd 0.54) | ||
| typedef void (*t_signal_setmultiout_fn)(t_signal **, int); | ||
| static t_signal_setmultiout_fn g_signal_setmultiout; |
There was a problem hiding this comment.
i find it a bit annoying that this commit mixes the renaming of the typedef of an unrelated function with the fix for the missing glist_findrtext.
There was a problem hiding this comment.
true - this is not related. i was reconsidering those type names with the additional function. but it should be fine without this change (struggling a bit with what's "good practice" there). updated the PR.
ben-wes
force-pushed
the
fix/glist_getrtext
branch
from
e4524e1 to
52d111a
Compare
|
@agraef this would be great to have in a new release! 🙏 |
|
@dvzrv this is actually part of the current release on deken. i have been inactive here for quite a bit now... but we should certainly reflect these changes here, too. Will try to show some more initiative in the next weeks! thanks for the reminder. :) |
|
Thanks for the additional info! |
3 participants
this uses the mechanism we already had in place for the multichannel handling.
uses the new
glist_getrtextif present and otherwise falls back to the previousglist_findrtexttested with Pd vanilla for official
0.55-2build and currentmasterincluding the change.