Add default-directory' to body' in `org-babel-execute:tmux'#19
Open
YorkZ wants to merge 3 commits intoahendriksen:masterfrom
Open
Add default-directory' to body' in `org-babel-execute:tmux'#19YorkZ wants to merge 3 commits intoahendriksen:masterfrom
default-directory' to body' in `org-babel-execute:tmux'#19YorkZ wants to merge 3 commits intoahendriksen:masterfrom
Conversation
Change the current directory to `default-directory' before executing commands in `org-babel-execute:tmux'. This allows the `:dir' header argument to take effect in the tmux code block.
In the `ob-tmux--execute' and `ob-tmux--start-terminal-window' functions, replace the non-blocking `start-process' function with the blocking `call-process' function to ensure that the operation is completed before returning. This also allows the function to handle errors by checking the return value of `call-process'. - Use `call-process' instead of `start-process' - Check return value of `call-process' and handle error
In the `org-babel-execute:tmux' function, if the current session is a default session, kill it before creating a new one. This ensures that a new session is always created, even if a default session already exists. This is necessary for safety concerns, as reusing the default session may result in unexpected behavior due to leftover variables from previous sessions. - Check if current session is default session - Kill default session before creating new one
|
Hi This fix would be very useful to me. Could you merge it and create a new release ? On the other hand, if you do not want to maintain this project anymore, please say so, and hopefully someone will take over. Thanks for this package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I've made a change to
ob-tmux.elthat addsdefault-directoryto thebodyof theorg-babel-execute:tmuxfunction. This allows the:dirheader argument to take effect intmuxcode blocks.Please let me know if you have any questions or concerns about this change.
Thank you for maintaining this package.
Sincerely,
York