Respect device selection in system stats#72
Merged
loribonna merged 2 commits intoaimagelab:masterfrom Nov 22, 2025
Merged
Conversation
…rbage collection and cache clearing
loribonna
approved these changes
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I encountered severe performance degradation when enabling
--devicelog
uv run main.py --model sgd --dataset seq-cifar100 --device 1 --n_epochs 1 --lr 1e-3CUDA_VISIBLE_DEVICES=1 uv run main.py --model sgd --dataset seq-cifar100 --n_epochs 1 --lr 1e-3
As you can see, specifying
--deviceis 6.6 times slower than usingCUDA_VISIBLE_DEVICES.The PR is the GPT-5.1-Codex solution. You can merge or refer to it. I tested it and it worked well.
Summary
args.deviceinto stats tracking in the training loops (including deprecated path)Context
When all GPUs are visible, stats collection scanned every GPU each step and flushed CUDA caches, making
--device 1slower than masking viaCUDA_VISIBLE_DEVICES=1.