This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Enable plugins to support multiple renderings of same component#24
Open
dpuscher wants to merge 3 commits intoairbnb:masterfrom
Open
Enable plugins to support multiple renderings of same component#24dpuscher wants to merge 3 commits intoairbnb:masterfrom
dpuscher wants to merge 3 commits intoairbnb:masterfrom
Conversation
ljharb
reviewed
Dec 11, 2019
Enables support for rendering multiple components with the same name in one request
ljharb
reviewed
Dec 12, 2019
Use hash rockets Co-Authored-By: Jordan Harband <[email protected]>
Use hash rockets Co-Authored-By: Jordan Harband <[email protected]>
Author
|
Btw, I fixed your annotations @ljharb 🙂 |
viktorianer
approved these changes
Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the plugins feature passes a hash of hypernova-jobs to the callbacks
(e.g.
{ 'component_name.js': { :name => 'component_name.js', :data => {} } }).This makes it impossible to render a single component more than once per request when using plugins, although hypernova supports it by default.
This PR changes this behavior and passes the jobs array from
hypernova_batchto the plugin functions, so all jobs can be process equally.(e.g.
[{ :name => 'component_name.js', :data => {} }, ...]).I changed the version to
2.0.0since this is a breaking change for everyone who is using plugins that useprepare_request,send_request?,will_send_request,on_successoron_errorsince they all receive an array instead of hash now.