Skip to content

maxi297/implement proposal 2 #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maxi297 wants to merge 7 commits into from
Closed

maxi297/implement proposal 2 #129

maxi297 wants to merge 7 commits into from

Conversation

@maxi297
Copy link
Contributor

@maxi297 maxi297 commented May 6, 2025 •
edited
Loading

Proposal 2 documented here for the destination discovery

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "maxi297/implement proposal 2". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

maxi297
maxi297 commented May 6, 2025
View reviewed changes
protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml
- overwrite
#- upsert_dedup # TODO chris: SCD Type 1 can be implemented later
- append_dedup # SCD Type 1 & 2
- insert
Copy link
Contributor Author

@maxi297 maxi297 May 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that these do not need to be returned in the spec, we could have another enum that does not depend on DestinationSyncMode to describe the different operation modes for Data Activation but it would probably require to update the configured catalog as we intended to pass the information as an input of write there

maxi297
maxi297 commented May 6, 2025
View reviewed changes
protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml Outdated
items:
type: string
record_matchers:
description: If an object can be matched in the destination, this is the list of keys that can be used in order to match the object.
Copy link
Contributor Author

@maxi297 maxi297 May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a different compared to the previous proposal to use json_schema to convey the information: we can more easily support composite/nested matchers if we want

@maxi297 maxi297 changed the title Maxi297/discovered destination maxi297/implement proposal 2 May 7, 2025
@maxi297
Copy link
Contributor Author

maxi297 commented May 28, 2025 •
edited
Loading

Proposal 3 has been merged

@maxi297 maxi297 closed this May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@joeykmh joeykmh joeykmh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxi297 @joeykmh