feat: rename schema to json-schema #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I was trying to update destination-salesforce and destination-customer-io with the latest changes and the fact that the field for the json schema is called
schemaclashes with pydantic reserved wordschemawhich has the side effect of having the field named asschema_instead ofschema. This problem occurs in two places:schema_instead of justschema. I’m not too attached to fixing this right now because we were looking into having the destinations in Kotlin but it is bad DXschema_instead ofschemaand this one is an issue as it does not allow us to return the right objectThere are a couple of paths forward I see:
_schemain Python but fix the serialization as suchschematojson_schemahere and avoid the Python dataclass naming project altogether but it’ll require us to update existing code (basically updateschematojson_schemaFor now, we decided to go with solution 3