Feature/external seq/espresso/v3/patch 1#9
Merged
ComputerKeeda merged 8 commits intofeature/external-seq/espresso-developfrom Oct 4, 2024
Merged
Conversation
Updated the upgrade handler to initialize the Trackgate module and manage the capability index. Added logic to create and register Trackgate Keeper and AppModule, while ensuring the capability index is not reset if already initialized. Also commented out some platform-specific build targets in the Makefile for streamlined builds.
Refactor and enhance upgrade handler functionality
Refactor how station IDs are converted to byte slices before database operations to enhance clarity and consistency. This change impacts `msg_server_schema_creation.go` and `msg_server_init_station.go`, ensuring all station ID bytes are handled uniformly.
Refactor byte conversion for station ID
Refactor `module.AppModule` to `appmodule.AppModule` for consistency in imports. Additionally, remove deprecated `Name` method and obsolete endpoint definitions from the OpenAPI spec. This cleanup improves module organization and API clarity.
This change improves schema key generation by replacing the use of UUID with a SHA-256 hash. The new method combines creator, station ID, and version to ensure a unique and consistent key. This enhances security and integrity of schema keys.
Comment out the Trackgate Keeper initialization code as it appears to be unused, which will clean up the code and potentially prevent future maintenance issues related to this section.
The Trackgate module integration code has been commented out and its import removed. This change suggests that the module is no longer required or will be handled differently in subsequent updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary:
This PR updates key components in our Espresso integration branch. Key enhancements include:
Branches Involved:
feature/external-seq/espresso/v3/patch-1feature/external-seq/espresso-develop