Fix PEP-8 violations reported by flake8 on test/benchmark folder#1000
Merged
datapythonista merged 6 commits intoairspeed-velocity:masterfrom Feb 8, 2022
Merged
Fix PEP-8 violations reported by flake8 on test/benchmark folder#1000datapythonista merged 6 commits intoairspeed-velocity:masterfrom
datapythonista merged 6 commits intoairspeed-velocity:masterfrom
Conversation
LucyJimenez
changed the title
Member
datapythonista
left a comment
datapythonista
left a comment
There was a problem hiding this comment.
Looks good. Added few comments.
We also need to rebase (merge master into your branch) and add the fixed files to be checked by flake8.
test/benchmark/params_examples.py
Outdated
| from __future__ import (absolute_import, division, print_function) | ||
|
|
||
| import os | ||
| import os # noqa F401 unused import |
Member
There was a problem hiding this comment.
Any reason why not to remove this import if it's unused?
test/benchmark/subdir/time_subdir.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| import time | |||
| import time # noqa F401 unused import | |||
test/benchmark/timeraw_examples.py
Outdated
Comment on lines
+7
to
+8
| import inspect # Checked below. # noqa F401 unused import | ||
| import sys # noqa F401 unused import |
datapythonista
approved these changes
Feb 8, 2022
Member
datapythonista
left a comment
datapythonista
left a comment
There was a problem hiding this comment.
Thanks @LucyJimenez, looks great, ping me om green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check flake8 and fix pep8 issues related on :