Fix PEP-8 violations reported by flake8 on asv/util.py#1007
Fix PEP-8 violations reported by flake8 on asv/util.py#1007datapythonista merged 12 commits intoairspeed-velocity:masterfrom
Conversation
datapythonista
left a comment
datapythonista
left a comment
There was a problem hiding this comment.
Looks good, thanks for the fixes. Added couple of comments, but nice contribution.
asv/util.py
Outdated
| dots = False | ||
| else: | ||
| debug_log = lambda c: None | ||
| debug_log = lambda c: None # noqa |
There was a problem hiding this comment.
We shouldn't have bare noqa, we should always specify the error we want to ignore, and why.
In this case, why we don't fix the error properly?
There was a problem hiding this comment.
You are right. I was checking the other changes first, and I'm going to fix them.
asv/util.py
Outdated
| # Flush and disconnect debug log, if any | ||
| debug_log(None) | ||
| debug_log = lambda c: None | ||
| debug_log = lambda c: None # noqa |
asv/util.py
Outdated
|
|
||
|
|
||
| def human_list(l): | ||
| def human_list(non_human_list): |
There was a problem hiding this comment.
This is a normal list that wants to be printed in a human readable way. non_human_list doesn't seem to be a very clear name of what it is, maybe better just input or input_list or even list_to_format.
Co-authored-by: Marc Garcia <garcia.marc@gmail.com>
datapythonista
left a comment
datapythonista
left a comment
There was a problem hiding this comment.
Thanks @LucyJimenez, looks great.
|
Can you rebase please? |
Co-authored-by: Marc Garcia <garcia.marc@gmail.com>
…into check_flake8_02
…into check_flake8_02
|
Can you fix the conflicts please? |
|
Thanks @LucyJimenez, really nice! |
2 participants
closes https://github.com/pandas-benchmarks-grant/board-issues/issues/6
Fix pep8 issues on util.py