Fix flake8 issues on asv/commands/run.py#1082
Fix flake8 issues on asv/commands/run.py#1082datapythonista merged 9 commits intoairspeed-velocity:masterfrom
Conversation
asv/commands/run.py
Outdated
| if range_spec is None: | ||
| try: | ||
| commit_hashes = list(set([repo.get_hash_from_name(branch) for branch in conf.branches])) | ||
| commit_hashes = list(set([(repo.get_hash_from_name(branch) for |
There was a problem hiding this comment.
You are adding a parenthesis after the squared bracket. That is changing the code, instead of the comprehension returning a list of the iterated items, this is returning a list with a single value which is a generator. This is why tests are failing.
There was a problem hiding this comment.
Thank you for the explanation. I'm going to fix it!
|
The CI problem is unrelated to your changes. We should create an issue, and mention that this happens sometimes (seems like the conda servers are not very reliable, something that it's probably going to fix itself, but better to have an issue, in case something can be done in our end). Then, we've got these files excluded from flake8 validation in the CI. We should stop excluding them if you are fixing their errors, so we see this is working as expected, and no more style errors can be introduced to those files in future PRs. |
|
Thanks @LucyJimenez, very nice |
2 participants
Closes #1065
Clean out the
run.pyfiles to follow Flake8 standards on the asv/commands folder.