Move all test/tools.py fixtures to conftest.py file#1114
Move all test/tools.py fixtures to conftest.py file#1114datapythonista merged 8 commits intoairspeed-velocity:masterfrom
Conversation
dorothykiz1
changed the title
setup.cfg
Outdated
| test/test_continuous.py, | ||
| test/test_util.py, | ||
| test/test_find.py, | ||
| test/tools.py, |
There was a problem hiding this comment.
Why do we need to get tools.py back here? I guess there is a reason, but seems like we're just removing a couple of functions from there, if things were passing, they should still pass now.
There was a problem hiding this comment.
I added it as it was complaining about flake8 issues, I remember you had advised me not to mix issues.
Could my approach be wrong or i fix the unused import flake8 issues in the file?
There was a problem hiding this comment.
If the file is now passing the flake8 tests in master, and it's failing in this PR, it means you are introducing them.
So, not mixing things is a good idea, and we shouldn't probably fix existing flake8 issues here with the move. But the flake8 errors here are caused by your changes, so it's fine to fix them.
There was a problem hiding this comment.
Thanks for this,let me fix this
|
@datapythonista this PR is ready for your review again |
|
Sorry, this has conflicts with your other PR I just merged. Can you resolve them please? |
|
Tests are failing. Looks like you removed the decorator making |
|
Thanks @datapythonista I have worked on this,you can check again on green |
|
Thanks @dorothykiz1, very nice! |
2 participants
xref #1030