TST/DEPS: monkeypatch stdin, remove six from deps#1136
Merged
datapythonista merged 2 commits intoairspeed-velocity:masterfrom Mar 12, 2022
Merged
TST/DEPS: monkeypatch stdin, remove six from deps#1136datapythonista merged 2 commits intoairspeed-velocity:masterfrom
datapythonista merged 2 commits intoairspeed-velocity:masterfrom
Conversation
datapythonista
approved these changes
Mar 12, 2022
Member
datapythonista
left a comment
datapythonista
left a comment
There was a problem hiding this comment.
Thanks @fangchenli, very nice clean up. Added couple of ideas, in case you want to implement them, but happy to merge it whenever you're happy with this.
CC: @dorothykiz1
Member
|
Makes sense, thanks @fangchenli |
This was referenced Mar 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #909
close #1076
close #1040