BUG: Fix multiple Python version usage#1444
Merged
mattip merged 7 commits intoairspeed-velocity:mainfrom Nov 24, 2024
Merged
Conversation
HaoZeke
commented
Nov 24, 2024
Contributor
|
Thanks @HaoZeke |
jder
reviewed
May 5, 2025
| # previously, the user provided environment was assumed to handle the python version | ||
| mamba_pkgs = [ | ||
| util.replace_python_version(pkg, self._python) for pkg in mamba_pkgs | ||
| ] |
Contributor
There was a problem hiding this comment.
@HaoZeke @mattip sorry if I'm missing something, but it looks like if you do not have an environment file, the python version specified in asv.conf.json no longer gets passed to mamba after this change. (ie if there is no python= constraint before this line runs, we never add one) Perhaps we should restore the python={self._python} in the initialization of mamba_pkgs?
This was referenced May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1294. Basically ensures that the
asv.configdefinedpythontakes precedence over the one written into anenvironment.ymlfile. This may cause resolution issues if there are a lot of pinned packages in the file, but that's basically user error.Also fixes a subtle bug within the
mambaplugin which caused incorrect environments to be created for multiple python versions.