Rename load_json cleanup= option to js_comments=#764
Merged
pv merged 1 commit intoairspeed-velocity:masterfrom Oct 27, 2018
Merged
Rename load_json cleanup= option to js_comments=#764pv merged 1 commit intoairspeed-velocity:masterfrom
pv merged 1 commit intoairspeed-velocity:masterfrom
Conversation
The JSON comment syntax is nonstandard, and significantly reduces the loading speed. Rename the option and change the default, to ensure is is not used unnecessarily. Also remove Config.update --- since update_json throws away the comments, it's not really possible to update the API number in the config file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON comment syntax is nonstandard, and significantly reduces the
loading speed.
Rename the option and change the default, to ensure is is not used
unnecessarily.
Also remove Config.update --- since update_json throws away the
comments, it's not really possible to update the API number in the
config file.