Add 'asv check' command for a quick check for benchmark suite validity#782
Merged
pv merged 3 commits intoairspeed-velocity:masterfrom Jan 2, 2019
Merged
Add 'asv check' command for a quick check for benchmark suite validity#782pv merged 3 commits intoairspeed-velocity:masterfrom
pv merged 3 commits intoairspeed-velocity:masterfrom
Conversation
pv
force-pushed
the
check
branch
3 times, most recently
from
ab16ed1 to
bb04646
Compare
The 'check' command catches build failures, non-importability of the benchmark suite, and wrong number of arguments to benchmark methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'check' command catches build failures, non-importability of the
benchmark suite, and wrong number of arguments to benchmark methods.
The
asv devcommand can also be used to check validity, but it can be muchmore expensive as it actually runs the benchmark target code.