Virtualenv no longer supports --no-site-packages; remove it.#917
Merged
pv merged 6 commits intoairspeed-velocity:masterfrom May 14, 2020
Merged
Conversation
Contributor
Author
|
The pyflakes errors look unrelated. I suspect the appveyor errors are as well, but I don't know the configuration well enough to tell. I doubt the PyPy failures are related, but I did what I could to fix them. It doesn't seem to have worked, and I don't have access to a machine with PyPy. |
For some reason I had ">-", which is not a thing.
It should also be possible to `$TRAVIS_PIP install -r requirements-dev.txt`
Collaborator
|
Thanks, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got crashes when trying to use asv with latest virtualenv.
I think
virtualenv >= 20.0.0b1removed--no-site-packages, with no readily apparent replacement.However,
virtualenv >= 1.7apparently has this as the default, so that may be less needed now than it once was.It may be worth adding a setuptools
virtualenvextra to make sure the virtualenv version is recent enough.Closes #906
Alternate: #905