fix(security): mitigate ReDoS in compile-dots.js by avoiding regex match on tainted code#2591
Open
hdsenevi wants to merge 1 commit intoajv-validator:v6from
Open
fix(security): mitigate ReDoS in compile-dots.js by avoiding regex match on tainted code#2591hdsenevi wants to merge 1 commit intoajv-validator:v6from
hdsenevi wants to merge 1 commit intoajv-validator:v6from
Conversation
|
We are really waiting for this to be released! Thank you @hdsenevi for the quick fix! |
…tch on tainted code
038f516 to
7d27d66
Compare
Author
|
Hi @epoberezkin, I see PR #2588 was closed in favor of #2590. The ReDoS issue still appears to be present in ajv@6.14.0. This PR proposes a fix for that. VerificationI verified the vulnerability and the fix locally with the Snyk CLI locally: Before: After: Happy to adjust the approach or wording if you’d prefer a different direction for the v6 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
What changes did you make?
Is there anything that requires more attention while reviewing?